Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirection based on location header for methods other than HEAD #1410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snosratiershad
Copy link
Contributor

The location header can be provided with methods other than HEAD.

@fviard
Copy link
Contributor

fviard commented Jan 13, 2025

Could you give me a little bit more context of why it is needed or with which server you are encountering an issue that can motivate this change?

Because from my point of view, the kind of "redirection" that we are looking for are supposed to be "application data" that is in the body, and so, if we don't have a data and that it is not a HEAD request, it might probably mean that we are not targeting a wrong service or endpoint.

@snosratiershad
Copy link
Contributor Author

@fviard, redirection is not always initiated by a s3 system, it could be initiated by gateways, etc.
My case was trying to list my objects from ArvanCloud S3, and got redirection response with GET method. So I fixed it for myself using changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants